Skip to content

Add Examples for File #23646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2015
Merged

Add Examples for File #23646

merged 1 commit into from
Mar 25, 2015

Conversation

steveklabnik
Copy link
Member

This is pretty basic, but it's nice to have something.

r? @alexcrichton

/// # Examples
///
/// ```no_run
/// use std::io::prelude::*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the prelude can be omitted for for the examples that don't actually do any reading/writing

@alexcrichton
Copy link
Member

r=me after removing the preludes which I don't think are necessary. Or r=me if they are!

This is pretty basic, but it's nice to have something.
@steveklabnik
Copy link
Member Author

Ahh good call. They're not, they just got put in as part of the copy/paste.

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton rollup

@bors
Copy link
Collaborator

bors commented Mar 24, 2015

📌 Commit a34e87f has been approved by alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 24, 2015
This is pretty basic, but it's nice to have something.

r? @alexcrichton
@bors bors merged commit a34e87f into rust-lang:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants