Stabilize some stragglers in std::option
#23771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks as `#[stable}`: * `ok_or` * `ok_or_else` * `iter_mut` * `cloned` Similarly to `IteratorExt::cloned`, the `cloned` method is pared down to work only on `Option<&T>`. Thus, this is a: [breaking-change]
| reason = "recently added as part of collections reform")] | ||
| impl<'a, T: Clone> Option<&'a T> { | ||
| /// Maps an Option<&T> to an Option<T> by cloning the contents of the Option. | ||
| #[stable(feature = "rust1", since = "1.0.0")] |
There was a problem hiding this comment.
I haven't really felt the need to stabilize this in the past as it seems more niche than IteratorExt::cloned. Did you have some specific use-cases in mind?
There was a problem hiding this comment.
No burning need here. The motivation is exactly the same as for iterators.
There was a problem hiding this comment.
(The fact that iterators have a stable version of this method, to me, justifies it as a somewhat conventional thing to provide, in that there's not much additional cognitive overhead here. YMMV)
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
Marks as `#[stable}`: * `ok_or` * `ok_or_else` * `iter_mut` * `cloned` Similarly to `IteratorExt::cloned`, the `cloned` method is pared down to work only on `Option<&T>`. Thus, this is a: [breaking-change] r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks as
#[stable}:ok_orok_or_elseiter_mutclonedSimilarly to
IteratorExt::cloned, theclonedmethod is pared down towork only on
Option<&T>. Thus, this is a:[breaking-change]
r? @alexcrichton