Skip to content

Bump the version number to 1.1.0 #24366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SimonSapin
Copy link
Contributor

My understanding of release channels is that on May 15, 1.0.0-beta will become 1.0.0, and what’s currently in Nightly/master will become 1.1.0-beta and six weeks later 1.1.0. Therefore, current nighties should be be numbered 1.1.0-nightly.

My understanding of release channels is that on May 15, 1.0.0-beta will become 1.0.0, and what’s currently in Nightly/master will become 1.1.0-beta and six weeks later 1.1.0. Therefore, current nighties should be be numbered 1.1.0-nightly.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@SimonSapin
Copy link
Contributor Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Apr 13, 2015
@pnkfelix
Copy link
Member

@SimonSapin i don't know how this might affect your PR, but i think we are going to have one or two blanket merges from master to beta before we actually adopt the stricter structure.

This may mean that the use of the 1.1.0 version number should wait until after we do the last blanket merge.

@steveklabnik
Copy link
Member

Yup, it isn't quite time for this patch yet. I have a work item to lay out the branching strategy, should have it today or tomorrow.

@SimonSapin
Copy link
Contributor Author

This might not be the right way to do it, but AFAIU rustc --version is current nightlies should say 1.1, and 1.2 in the next cycle, etc. But maybe 1.0 is special and this is not worth the pain it would cause for planned blanket merges to beta.

@SimonSapin
Copy link
Contributor Author

Feel free to close at will.

@steveklabnik
Copy link
Member

The pre-1.0 cycle is gonna end up being a bit weird in exactly this kind of way.

I don't mind just leaving it open, we will need this soonish.

@steveklabnik
Copy link
Member

@brson we did the beta fork, so do we want this patch now?

@steveklabnik
Copy link
Member

superseded by #24670

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants