Skip to content

Add long diagnostics for E0018 #24525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2015
Merged

Add long diagnostics for E0018 #24525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a6980c
Add long explanation for E0018
GuillaumeGomez Apr 17, 2015
737005a
Fix typos
GuillaumeGomez Apr 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/librustc/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,29 @@ variant constructors or struct constructors (for unit or tuple structs). This
is because Rust currently does not support compile-time function execution.
"##,

E0018: r##"
The value of static and const variables must be known at compile time. You
can't cast a pointer as an integer because we can't know what value the
address will take.

However, pointers to other constants' address are allowed in constants,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, grammatically, it needs to use "address_es_" (plural) here, since you have an apostrophe after the "s" in "constants'".

That, or make it consistently singular, like so:

"However, a pointer to another constant's address is allowed in a constant. Example: ..."

example:

```
const X: u32 = 50;
const Y: *const u32 = &X;
```

Therefore, casting one of these non-constant pointers to an integer results
in a non-constant integer whichs lead to this error. Example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "whichs lead to this error" is not correct. Should be "which"


```
const X: u32 = 50;
const Y: *const u32 = &X;
println!("{:?}", Y);
```
"##,

E0020: r##"
This error indicates that an attempt was made to divide by zero (or take the
remainder of a zero divisor) in a static or constant expression.
Expand Down Expand Up @@ -398,7 +421,6 @@ register_diagnostics! {
E0014,
E0016,
E0017,
E0018,
E0019,
E0022,
E0079, // enum variant: expected signed integer constant
Expand Down