Move the SC constants for macos to an accessible module (fixes #24374 for mac). #25093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 2a46976 with merge 4f9d076... |
|
💔 Test failed - auto-mac-64-opt |
|
r? |
|
⌛ Testing commit 4de61c6 with merge 91cc61d... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: r=alexcrichton |
|
📌 Commit f77c9c9 has been approved by |
|
⌛ Testing commit f77c9c9 with merge 7d43e55... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit f77c9c9 with merge 79893d7... |
|
💔 Test failed - auto-mac-64-opt |
…ang#24374 for mac). These constants were added in 6f54ce9 and e8fbd1c to a consts module that is behind a gate. I have not confirmed that these constants do indeed work on either OSX or iOS. It appears that some of the constants may actually belong in a POSIX module, but I didn't make these changes here because I don't have access to the POSIX standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants were added in 6f54ce9 and
e8fbd1c to a consts module that is behind a
gate.
I have not confirmed that these constants do indeed work on either OSX or iOS.