Add error explanations for E0185, E0186, E0202, E0326. Fix E0053. #25593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
| impl Foo for Bar { | ||
| // error, method `foo` has a `&self` declaration in the trait, but not in | ||
| // the impl | ||
| fn foo(&self) {} |
There was a problem hiding this comment.
Did this mistakenly include &self?
|
r=me with just a minor nit, thanks! |
|
@alexcrichton I just realized I missed a test with the E0202 change. I've fixed it and it now passes |
bors
added a commit
that referenced
this pull request
May 26, 2015
Changes: - adds explanations for E0185, E0186, E0202, E0326 - fixes the explanation for E0053. The previous description was too narrow; there are other error cases. - changes the error message for E0202 to be specific for associated types, since it seems inherent associated constants are implemented. Part of #24407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Part of #24407