book: explanation that String -> &str coercion doesn't happen for &str traits #25742
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
| of type `ToSocketAddrs`. A `&str` is okay but a `String` must be explicitly | ||
| converted using `&*`. | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
this should probably be tagged no_run as well, because it won't work, since there's no server, yeah?
|
Thanks so much! r=me after the nit |
|
I've added |
|
@bors: r+ rollup |
|
📌 Commit 2b3354c has been approved by |
|
Thanks so much! |
A few of us [over on the forum](https://users.rust-lang.org/t/string-type-coercion-in-rust/1439) have been tripped up by this distinction, which I don't think is mentioned. It's kind of logical if you read the "Deref coercions" page and squint a bit but I think it would be nice to explain it directly. Here's one way we could clarify it.
A few of us over on the forum have been tripped up by this distinction, which I don't think is mentioned. It's kind of logical if you read the "Deref coercions" page and squint a bit but I think it would be nice to explain it directly. Here's one way we could clarify it.