Skip to content

Fix off by one in the iterator documentation #25927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2015
Merged

Conversation

stevegury
Copy link
Contributor

(1..100).map(|x| x + 1) is actually mapping [1,100) to [2,101)

`(1..100).map(|x| x + 1)` is actually mapping [1,100) to [2,101)
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mitaa
Copy link
Contributor

mitaa commented May 31, 2015

Are you sure? (Range has an exclusive upper bound)
http://doc.rust-lang.org/nightly/std/ops/struct.Range.html

println!("{:?}", (1..100).map(|x| x + 1).collect::<Vec<usize>>());
// [2, 3, 4, ... 98, 99, 100]

@mitaa
Copy link
Contributor

mitaa commented May 31, 2015

I see.. the off by one error is a bit further up
http://doc.rust-lang.org/book/iterators.html#iterators

This code, for example, does not actually generate the numbers 1-100, instead creating a value that merely represents the sequence:
let nums = 1..100;

Fix the actual off by one
@stevegury
Copy link
Contributor Author

@mitaa you're right, thanks for correcting me.
I updated the right off by one.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 31, 2015

📌 Commit bef9361 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented May 31, 2015

⌛ Testing commit bef9361 with merge 60926b8...

bors added a commit that referenced this pull request May 31, 2015
`(1..100).map(|x| x + 1)` is actually mapping [1,100) to [2,101)
@steveklabnik
Copy link
Member

Thanks @stevegury !

@bors bors merged commit bef9361 into rust-lang:master May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants