-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Sized fastpath #26023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sized fastpath #26023
Conversation
This seems to improve performance by the same 2-3% of my selection fast-path.
AFAICT there is no chance of leakage of cached results that depend on the parameter environment, though there might be other gotchas I'm not aware of. |
I am using the same caching logic as before. |
You're totally right, my bad. @bors r+ |
📌 Commit 595409d has been approved by |
Performance numbers:
|
@arielb1 is that saying it took... longer? @bors r- |
I mixed them up |
@bors r+ |
📌 Commit 39e6855 has been approved by |
r? @eddyb The change to `trans::common::type_is_sized` is because we currently abort, rather than return random results, on overflow.
r? @eddyb
The change to
trans::common::type_is_sized
is because we currently abort, rather than return random results, on overflow.