Extend examples for AtomicBool::{swap, compare_and_swap} #26177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -285,7 +286,8 @@ impl AtomicBool { | |||
| /// | |||
| /// let some_bool = AtomicBool::new(true); | |||
| /// | |||
| /// let value = some_bool.store(false, Ordering::Relaxed); | |||
| /// assert_eq!(true, some_bool.compare_and_swap(false, false, Ordering::Relaxed)); | |||
There was a problem hiding this comment.
Could this also perhaps show off an example of a successful compare-and-swap? Also, our assertions are typically assert_eq!(actual, expected) instead of the other way around I believe.
There was a problem hiding this comment.
I prefer assert_eq!(actual, expected) as well, but all other examples for AtomicBool used assert_eq!(expected, actual) and I wanted to stay consistent. Should I swap the arguments of all other asserts in this file as well?
Swap arguments of `assert_eq!` calls, insert additional assertions here and there. Closes rust-lang#26169.
|
Added successful |
bors
added a commit
that referenced
this pull request
Jun 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26169.
r? @steveklabnik