-
Notifications
You must be signed in to change notification settings - Fork 13.4k
README: make it clear rustc is the compiler #26373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I think current text makes it pretty clear rustc is, in fact, the Rust compiler. |
@nagisa the listing made it look like The Rust compiler and rustc could be different things, so this PR makes it more clear. |
Yes, it was already clear.
|
@nikomatsakis only to those who are already aware that rustc is the Rust compiler |
@tshepang current sentence correctly uses an appositive which
I strongly suggest checking out the examples in linked pages if you are not convinced. |
@nagisa I am aware of that usage, and that the English used here is valid. To prove it, here's another alternative that would also make things less ambiguous:
That's less ambiguous than the current:
|
Given that we've all seen typos, poor grammar, and the like peppering various code-related documents, there is at least one possibility of ambiguity in the original sentence. This possible ambiguity arises between parsing the sentence as having poor grammar and parsing the sentence as exactly written. The change given uses English language features such as the parenthetical to significantly decrease the possibility of that ambiguity for readers skimming the text. I think this is a pragmatic change from that perspective. |
Support finally! Thanks @soltanmm. |
@@ -4,7 +4,7 @@ Rust is a systems programming language that is fast, memory safe and | |||
multithreaded, but does not employ a garbage collector or otherwise | |||
impose significant runtime overhead. | |||
|
|||
This repo contains the code for `rustc`, the Rust compiler, as well | |||
This repo contains the code for the compiler (`rustc`), as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we just remove the comma separation, and write it like this? This repo contains the code for the Rust compiler rustc
, as well as standard libraries, tools and documentation for Rust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the English with your suggestion is not valid, given the meaning intended.
@bors: r+ rollup |
📌 Commit 1cf6a82 has been approved by |
No description provided.