Hacky patch to configure for Apple's LLVM #26653
Conversation
Added 7.0* to the clang versions accepted so it will compile on OS X El Capitan for now.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Please no. Everybody will certainly forget about this hack and once LLVM itself reaches 7.0 versions everybody will be confused about all kinds of breakage (Windows 9 story, all over again). I’d fix this by asking Apple to not do stupid things instead. Related: #26292. |
|
I agree with @nagisa, can this be done in a more principled fashion which detects the newer version string? |
|
Alright, understood. I just wanted to get things working for me again. It seems there are two options here. Above in the config file there is a check to force clang for Mac OS 10.9 and up which already checks for the apple specific llvm version, the newer version string as @alexcrichton called it, some logic for this could be put in there, or around the normal version check we could add an extra if/fi to branch for apple llvm, which would be preferable? The former keeps the Mac OS 10.9+ specific checks in one place, the latter keeps the version checking in one place, what do you guys think? |
|
If we're on OSX >= 10.9 I feel like it's probably safe to assume that the clang in question is of an ok version. |
Since Apple LLVM no longer reports which version of LLVM it's based off (starting with 7.0.0), I believe it's time to start checking Apple LLVM versions directly. The changes in this pull request update the `configure` script to check "Apple LLVM" versions independently if no "based off" version can be found. If a "based off" version is included, however, it will be preferred. (This is a less hacky version of #26653)
|
☔ The latest upstream changes (presumably #27006) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Support for this was added in #27006, so closing in favor of that. |
Added 7.0* to the clang versions accepted so it will compile on OS X El Capitan for now.