Expand docs for recv #26715
Expand docs for recv #26715
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| /// drop(send); | ||
| /// }); | ||
| /// | ||
| /// // `send` is now dropped, but the messages were still buffered |
There was a problem hiding this comment.
maybe this comment should be after the join?
There was a problem hiding this comment.
I put comments describing a line of code before that line, but i see what you're saying with the phrasing
There was a problem hiding this comment.
Yeah, I'm thinking temporarily, the "now" only applies after this statement.
|
tidy failed with some trailing whitespace |
|
Tidy fixed and I just removed the comment, I think it stands enough on its own, but maybe not? |
|
Hm, it's not entirely obvious. A possibility is something like "wait for the thread to finish so that the sender is dropped"? r=me with a comment like that or not, whatever you feel is best. |
Add an example, plus some text that covers the buffering nature of channels. Fixes rust-lang#26497
|
i like it, added |
|
@bors: r=huonw rollup |
|
📌 Commit 5564172 has been approved by |
Add an example, plus some text that covers the buffering nature of channels. Fixes #26497
Add an example, plus some text that covers the buffering nature of
channels.
Fixes #26497