Skip to content

Implement CoerceUnsized for rc::Weak #26727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2015
Merged

Implement CoerceUnsized for rc::Weak #26727

merged 3 commits into from
Jul 2, 2015

Conversation

remram44
Copy link
Contributor

@remram44 remram44 commented Jul 1, 2015

This is a simple addition, shouldn't change behavior.

Fixes #26704

I don't know if the coercion for Rc is tested, if it is this probably needs the same test with Weak.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Jul 1, 2015

Could probably do the same thing for arc::Weak. Tests are in src/test/run-pass/dst-coerce-rc.rs.

@remram44
Copy link
Contributor Author

remram44 commented Jul 1, 2015

I feel like maybe dst-coerce-rc.rs is more about testing the CoerceUnsized feature than checking it is implemented for the right types, but here you go.

@eddyb
Copy link
Member

eddyb commented Jul 1, 2015

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2015

📌 Commit 3278e79 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jul 2, 2015

⌛ Testing commit 3278e79 with merge c4b4f07...

bors added a commit that referenced this pull request Jul 2, 2015
This is a simple addition, shouldn't change behavior.

Fixes #26704

I don't know if the coercion for `Rc` is tested, if it is this probably needs the same test with `Weak`.
@bors bors merged commit 3278e79 into rust-lang:master Jul 2, 2015
@remram44 remram44 deleted the coerceunsized-weak branch July 16, 2015 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants