Skip to content

Update README.md #26745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update README.md #26745

wants to merge 1 commit into from

Conversation

irvifa
Copy link

@irvifa irvifa commented Jul 2, 2015

Added link for rust-lang and developer forum

Added link for rust-lang and developer forum
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1,13 +1,15 @@
# The Rust Programming Language

Rust is a fast systems programming language that guarantees
[(Rust)] is a fast systems programming language that guarantees
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you only need [] here, not the ().

@Gankra
Copy link
Contributor

Gankra commented Jul 27, 2015

@rvu95 can you fix the only nit?

Also cc @brson I know you've been conservative about this sort of thing in the past.

@brson
Copy link
Contributor

brson commented Jul 27, 2015

I'm already pretty dissatisfied with the existing first paragraph here and don't feel like the addition makes makes it more beautiful as written.

cc @steveklabnik

@steveklabnik
Copy link
Member

I am also pretty ambivalent about those changes.

@bors
Copy link
Collaborator

bors commented Aug 12, 2015

☔ The latest upstream changes (presumably #27688) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Member

@rvu95 it's been a loooong time since we've heard from you, and this PR hasn't been mergeable for two weeks. If you're interested in fixing up this PR, let me know, but until then, I'm going to give it a close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants