Skip to content

Add four regression tests #26988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2015
Merged

Add four regression tests #26988

merged 4 commits into from
Jul 17, 2015

Conversation

frewsxcv
Copy link
Member

No description provided.

@alexcrichton
Copy link
Member

@bors: r+ 0d326b50d490dbcac4a37f37a5791b3a23b3bc4f

Thanks!

@alexcrichton alexcrichton self-assigned this Jul 12, 2015
@bors
Copy link
Collaborator

bors commented Jul 13, 2015

⌛ Testing commit 0d326b5 with merge 9785dc5...

@bors
Copy link
Collaborator

bors commented Jul 13, 2015

💔 Test failed - auto-mac-64-opt

@frewsxcv
Copy link
Member Author

Woops! The expected error message for 23595-1.rs was incorrect; I just fixed it

@alexcrichton
Copy link
Member

@bors: r+ a8108802bd7516565bd55faa1300b62663419310

@bors
Copy link
Collaborator

bors commented Jul 13, 2015

⌛ Testing commit a810880 with merge ab6d66e...

@bors
Copy link
Collaborator

bors commented Jul 13, 2015

💔 Test failed - auto-mac-64-opt

@frewsxcv
Copy link
Member Author

Cool, I had another typo. Hopefully it should be okay now, sorry about that

@alexcrichton
Copy link
Member

@bors: r+ 28ff886

No worries!

@bors
Copy link
Collaborator

bors commented Jul 14, 2015

⌛ Testing commit 28ff886 with merge f71d988...

@bors
Copy link
Collaborator

bors commented Jul 14, 2015

💔 Test failed - auto-mac-64-opt

@frewsxcv
Copy link
Member Author

I'm not sure what I'm doing wrong with the expected error. If anyone has insight please let me know.

@frewsxcv
Copy link
Member Author

I just learned from @bluss that when reporting multiple compile errors on a single line, one needs to incrementally add ^ for each line (^, ^^, ^^^, etc.). I just made that change so this should be good to go again

tamird
tamird reviewed Jul 14, 2015
View reviewed changes
src/test/compile-fail/issue-23595-1.rs
type ChildKey;
type Children = Index<Self::ChildKey, Output=Hierarchy>;
//~^ ERROR: the value of the associated type `ChildKey`
//~^^ ERROR: the value of the associated type `Children`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also use //~| on this line i believe

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/rust-lang/rust/blob/master/src/test/compile-fail/array-not-vector.rs#L16

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: https://github.com/rust-lang/rust/blob/master/src/compiletest/errors.rs#L26

@alexcrichton
Copy link
Member

@bors: r+ 7954096

but also r=me if you wanna tweak the syntax a bit

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2015
@Manishearth
Rollup merge of rust-lang#26988 - frewsxcv:regression-tests, r=alexcr…
31d6716 
…ichton

   "body": null,
@bors bors merged commit 7954096 into rust-lang:master Jul 17, 2015
@frewsxcv frewsxcv deleted the regression-tests branch July 17, 2015 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @alexcrichton @bors @tamird