Skip to content

Added long diagnostics for E0254. #26992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Added long diagnostics for E0254. #26992

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8317f5
Added long diagnostics for E0254.
uatach Jul 12, 2015
8cdd1bc
Expanded diagnostics for E0254.
uatach Jul 12, 2015
1ff505f
Separated examples.
uatach Jul 12, 2015
22b0f51
Extended explanation for E0254.
uatach Jul 13, 2015
5782b07
Rewritten diagnostics for E0254.
uatach Jul 17, 2015
22eb539
Removed tabs on E0254.
uatach Jul 17, 2015
9ae62fd
Fixed example on E0254.
uatach Jul 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/librustc_resolve/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,31 @@ mod bar {
```
"##,

E0254: r##"
This error indicates that a `use` declaration added a symbol to the current
namespace that conflicts with a symbol added by an `extern crate` declaration.

An example of this error:

There's an external crate and it, also, can have no exports as foo.rs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"There is an external crate foo"


```
#![crate_type="lib"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this code example, it just confuses the situation

```

On the client code, bar.rs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our code,

(no need for a filename)


```
extern crate foo;

use inner_mod::foo; // error, this conflicts with the external crate's symbol

mod inner_mod {
pub mod foo { }
}
```
"##,

E0255: r##"
You can't import a value whose name is the same as another value defined in the
module.
Expand Down Expand Up @@ -205,7 +230,6 @@ register_diagnostics! {
E0157,
E0153,
E0253, // not directly importable
E0254, // import conflicts with imported crate in this module
E0257,
E0258,
E0364, // item is private
Expand Down