Skip to content

Default methods example: Show "(in)valid" case #27284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2015

Conversation

lastorset
Copy link
Contributor

Instead of bar/baz, use valid/invalid as default methods. This
illustrates why you might want default methods, and shows that you can
call other trait methods from a default method.

r? @steveklabnik

Instead of bar/baz, use valid/invalid as default methods. This
illustrates why you might want default methods, and shows that you can
call other trait methods from a default method.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Gankra
Copy link
Contributor

Gankra commented Jul 27, 2015

Nice! 👍

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

📌 Commit 7bec320 has been approved by Gankro

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

⌛ Testing commit 7bec320 with merge ec5765d...

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Jul 27, 2015 at 2:34 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-64-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/834


Reply to this email directly or view it on GitHub
#27284 (comment).

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

⌛ Testing commit 7bec320 with merge 8988043...

bors added a commit that referenced this pull request Jul 27, 2015
Instead of bar/baz, use valid/invalid as default methods. This
illustrates why you might want default methods, and shows that you can
call other trait methods from a default method.

r? @steveklabnik
@bors bors merged commit 7bec320 into rust-lang:master Jul 27, 2015
@lastorset lastorset deleted the default-methods branch November 21, 2015 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants