Use raw pointers to avoid aliasing violation in split_at_mut #27358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 95596bb has been approved by |
bluss
changed the title
|
I realized the commit log was wrong -- it reflected an earlier version. Updated commit log, pr text & title |
|
@bors r=aturon |
|
📌 Commit 73d4330 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2015
Use raw pointers to avoid aliasing violation in split_at_mut Fixes #27357
bors
added a commit
that referenced
this pull request
Jan 21, 2016
Use raw pointers to avoid aliasing in str::split_at_mut Introduce private functions from_raw_parts, from_raw_parts_mut for str to factor out the logic. We want to use raw pointers here instead of duplicating a &mut str, to be on safer ground w.r.t rust aliasing rules. This has already been fixed for slices in PR #27358, issue #27357
bors
added a commit
that referenced
this pull request
Jan 21, 2016
Use raw pointers to avoid aliasing in str::split_at_mut Introduce private function from_raw_parts_mut for str to factor out the logic. We want to use raw pointers here instead of duplicating a &mut str, to be on safer ground w.r.t rust aliasing rules. This has already been fixed for slices in PR #27358, issue #27357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use raw pointers to avoid aliasing violation in split_at_mut
Fixes #27357