-
Notifications
You must be signed in to change notification settings - Fork 13.5k
doc: prelude nits #27398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: prelude nits #27398
Conversation
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Should that be contains or contained? |
//! imported at the topmost level of every crate by default, as if the | ||
//! first line of each crate was | ||
//! imported at the topmost level of every crate by default, as if | ||
//! each crate contains the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to me, 'contains' sounds like it's the entire contents, not starting with. I would maybe say
Because
std
is required by most serious Rust software, it is imported at the topmost level of each crate by default. If this were explicit, it might look like this:
```ignore
extern crate std;
// your code here
```
like that. Whatcha think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not even inserted at the top of the crate (check -Z unstable-options --pretty=expanded
). I think it does not need to be mentioned where exactly it's inserted, as this is something of an implementation detail, and not such an important detail at that. It's good enough that it's inserted, somewhere.
@bors: r+ rollup |
📌 Commit 1d3818a has been approved by |
No description provided.