Skip to content

doc: prelude nits #27398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2015
Merged

doc: prelude nits #27398

merged 1 commit into from
Aug 4, 2015

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@tshepang
Copy link
Member Author

Should that be contains or contained?

@alexcrichton
Copy link
Member

r? @steveklabnik

//! imported at the topmost level of every crate by default, as if the
//! first line of each crate was
//! imported at the topmost level of every crate by default, as if
//! each crate contains the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to me, 'contains' sounds like it's the entire contents, not starting with. I would maybe say

Because std is required by most serious Rust software, it is imported at the topmost level of each crate by default. If this were explicit, it might look like this:

```ignore
extern crate std;

// your code here
```

like that. Whatcha think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not even inserted at the top of the crate (check -Z unstable-options --pretty=expanded). I think it does not need to be mentioned where exactly it's inserted, as this is something of an implementation detail, and not such an important detail at that. It's good enough that it's inserted, somewhere.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 3, 2015

📌 Commit 1d3818a has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 4, 2015
bors added a commit that referenced this pull request Aug 4, 2015
@bors bors merged commit 1d3818a into rust-lang:master Aug 4, 2015
@tshepang tshepang deleted the patch-5 branch September 30, 2015 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants