Add Win10 SDK lib subfolder name #27437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
force-pushed
the
win10-sdk
branch
5 times, most recently
from
d56317c to
967a578
Compare
| Some(e) => e, | ||
| None => return None, | ||
| }; | ||
| // This seems to work but is totally a hack |
There was a problem hiding this comment.
Could you expand this to:
So far it looks like the "ProductVersion" of the SDK corresponds to the folder name that the libraries are located in except that the folder contains an extra ".0". For now just append a ".0" to look for find the directory we're in. This logic will likely want to be refactored one day.
Signed-off-by: Peter Atashian <[email protected]>
bors
added a commit
that referenced
this pull request
Jul 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton