-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix minor mistakes in the book #27459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -540,7 +540,7 @@ fn main() { | |||
Philosopher::new("Gilles Deleuze", 1, 2), | |||
Philosopher::new("Karl Marx", 2, 3), | |||
Philosopher::new("Emma Goldman", 3, 4), | |||
Philosopher::new("Michel Foucault", 0, 4), | |||
Philosopher::new("Michel Foucault", 4, 0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come these changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They haven't. It is in the explanation.
This is the examples way of trying to evade a deadlock.
Therefore I have reverted the commit :S
Can you squash this please? r=me after |
@steveklabnik Rather all three :) |
it won't! github updates it just fine. |
\o/ |
Okay, I don't get it. Shouldn't @bors do something now? Help! |
@bors: r+ rollup |
📌 Commit 3dfab40 has been approved by |
@da-kid bors only listens to people with commit bit, sorry about that! you did it correctly otherwise :) |
Sorry :/