Skip to content

delete some old tests #27505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Conversation

steveklabnik
Copy link
Member

These are for syntaxes that haven't existed for a long time.

These are for syntaxes that haven't existed for a long time.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@tshepang
Copy link
Member

tshepang commented Aug 4, 2015

Aren't these tests still valid? Is it enough to just trust that the compiler rejects such syntax?

@nikomatsakis
Copy link
Contributor

they are indeed still valid tests, but then a regression here seems rather unlikely

@brson
Copy link
Contributor

brson commented Aug 5, 2015

@bors r+ Yeah, I think it's safe to assume anything here is also covered elsewhere.

@bors
Copy link
Collaborator

bors commented Aug 5, 2015

📌 Commit b5a7827 has been approved by brson

@brson
Copy link
Contributor

brson commented Aug 5, 2015

Oh, I didn't look closely before commenting. Still, I feel ok about removing them. Nobody's going to accidentally reimplement old syntaxes.

@bors
Copy link
Collaborator

bors commented Aug 5, 2015

⌛ Testing commit b5a7827 with merge 4f33e43...

bors added a commit that referenced this pull request Aug 5, 2015
These are for syntaxes that haven't existed for a long time.
@tshepang
Copy link
Member

tshepang commented Aug 6, 2015

Looks like there are other tests for old syntax. What should be done with them? I imagine these were only really useful pre-1.0?

@bors bors merged commit b5a7827 into rust-lang:master Aug 6, 2015
@steveklabnik steveklabnik deleted the exterminate_exterminate branch June 19, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants