Skip to content

Improve rustdoc search type filtering. #27515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 4, 2015
Merged

Improve rustdoc search type filtering. #27515

merged 1 commit into from Aug 4, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2015

Some small changes to (hopefully) make search more useful:

  • Less strict filtering, e.g:
    • searching for "fn: foo" now matches methods and trait functions as well.
    • searching for types also matches primitive types.
    • searching for const will also match associated constants (but there aren't any in std yet)
  • Changed searching for types to use the actual keyword "type" instead of the strange C-like "typedef".
  • Added const and macro to allowed keywords.

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

I like these changes, but this code isn't my area of expertise. @alexcrichton or @gankro or anyone else, what do you think?

@alexcrichton
Copy link
Member

@bors: r+ acf9d67

Thanks!

@Gankra
Copy link
Contributor

Gankra commented Aug 4, 2015

👍

@bors
Copy link
Collaborator

bors commented Aug 4, 2015

⌛ Testing commit acf9d67 with merge eb11d65...

bors added a commit that referenced this pull request Aug 4, 2015
Some small changes to (hopefully) make search more useful:

* Less strict filtering, e.g:
    * searching for "fn: foo" now matches methods and trait functions as well.
    * searching for types also matches primitive types.
    * searching for const will also match associated constants (but there aren't any in std yet)
* Changed searching for types to use the actual keyword "type" instead of the strange C-like "typedef".
* Added const and macro to allowed keywords.
@bors bors merged commit acf9d67 into rust-lang:master Aug 4, 2015
@ghost ghost deleted the rustdoc-search branch August 4, 2015 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants