Better FFI discipline #27548
Merged
Better FFI discipline #27548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub type UNWIND_HISTORY_TABLE = c_void; | ||
| // Opaque structs. | ||
| enum CONTEXT {} | ||
| enum UNWIND_HISTORY_TABLE {} |
There was a problem hiding this comment.
I believe these will need to stay pub to satisfy the no-private-types-exposed-in-public-signatures check
Other than that can you also remove the // Opaque struct comment on both of these? (it's pretty self explanatory).
r=me after those two nits!
bors
added a commit
that referenced
this pull request
Aug 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton