Use the right type for drop flag datums #27555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drop flags are Lvalue (and thus ByRef) datums that hold a u8 value, so their value type should be u8, not a pointer to u8.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @pnkfelix |
|
r? @pnkfelix I don't think we're using the type anywhere yet, otherwise we'd get type mismatches from LLVM. |
|
@bors r+ |
|
📌 Commit 38d627f has been approved by |
bors
added a commit
that referenced
this pull request
Aug 6, 2015
The drop flags are Lvalue (and thus ByRef) datums that hold a u8 value, so their value type should be u8, not a pointer to u8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drop flags are Lvalue (and thus ByRef) datums that hold a u8 value,
so their value type should be u8, not a pointer to u8.