Skip to content

syntax: fix use of "vector" for [x; n] literal and [x, y] patterns #27664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

birkenfeld
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 29945d5 rollup

Thanks!

@birkenfeld
Copy link
Contributor Author

Thanks for the review! I noticed that there is a whole section about "vector pattern matching" here: https://github.com/rust-lang/rust/blob/master/src/librustc_trans/trans/_match.rs#L141 - it probably needs a makeover, but I don't want to just blindly replace "vector" by "array" or "slice"...

@alexcrichton
Copy link
Member

Ah it's probably ok to basically leave as-is, I have a feeling most of it is about either slices or arrays, not necessarily vectors, but I'm also not super familiar with it.

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 11, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 12, 2015
@bors bors merged commit 29945d5 into rust-lang:master Aug 12, 2015
@birkenfeld birkenfeld deleted the patch-1 branch August 20, 2015 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants