Get make check working on MSVC
#27786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Ah and when I say "MSVC" I really mean 64-bit MSVC, unwinding doesn't work so hot in 32-bit MSVC just yet. Also, here's an example of a successful test run on the bots in dev: http://54.176.156.253/builders/auto-win-msvc-64-opt/builds/42 |
| // in VS 2013 it returns a double with the bit pattern 0x2 and in VS 2015 it | ||
| // returns 0x20000. | ||
| // | ||
| // For not just ignore this test entirely on MSVC as it's tested elsewhere |
* An apparent bug in VS 2013's implementation of the `exp2` function is worked around in one of flt2dec's tests.
alexcrichton
force-pushed
the
start-testing-msvc
branch
from
fbd2658 to
60ac0d8
Compare
|
@bors r+ |
|
📌 Commit 60ac0d8 has been approved by |
|
⌛ Testing commit 60ac0d8 with merge 91b14bb... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry On Thu, Aug 13, 2015 at 1:34 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
Aug 14, 2015
* An apparent bug in VS 2013's implementation of the `exp2` function is worked around in one of flt2dec's tests. Turns out this was the only fix necessary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exp2function is workedaround in one of flt2dec's tests.
Turns out this was the only fix necessary!