test: Don't panic if some tests failed #27869
Conversation
This commit removes the call to `panic!("Some tests failed")` at the end of all
tests run when running with libtest. The panic is replaced with
`std::process::exit` to have a nonzero error code, but this change both:
1. Makes the test runner no longer print out the extraneous panic message at the
end of a failing test run that some tests failed. (this is already summarized
in the output of the test run).
2. When running tests with `RUST_BACKTRACE` set it removes an extraneous
backtrace from the output (only failing tests will have their backtraces in
the output.
|
r? @brson |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit bfc4583 has been approved by |
|
Just wanted to mention that this prevents dropping of |
|
@nagisa do you have a specific problem in mind because of that? (NB. the process is exiting and the operating system will automatically reclaim the memory.) |
This commit removes the call to `panic!("Some tests failed")` at the end of all
tests run when running with libtest. The panic is replaced with
`std::process::exit` to have a nonzero error code, but this change both:
1. Makes the test runner no longer print out the extraneous panic message at the
end of a failing test run that some tests failed. (this is already summarized
in the output of the test run).
2. When running tests with `RUST_BACKTRACE` set it removes an extraneous
backtrace from the output (only failing tests will have their backtraces in
the output.
|
Only the fact that valgrind might complain.
|
This commit removes the call to
panic!("Some tests failed")at the end of alltests run when running with libtest. The panic is replaced with
std::process::exitto have a nonzero error code, but this change both:end of a failing test run that some tests failed. (this is already summarized
in the output of the test run).
RUST_BACKTRACEset it removes an extraneousbacktrace from the output (only failing tests will have their backtraces in
the output.