Refactor unix backtracing. NFC #27912
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Is all of this code movement? |
|
|
||
| // tracing impls: | ||
| #[cfg(not(all(target_os = "ios", target_arch = "arm")))] mod gcc_s; | ||
| #[cfg(all(target_os = "ios", target_arch = "arm"))] mod libbacktrace; |
There was a problem hiding this comment.
I think this module would be more appropriately named as something like unix_backtrace or backtrace_fn as libbacktrace is different from the backtrace function in libc.
Also, can this use #[path = "..."] and mod imp; for both cases to avoid having the same #[cfg] for the import and the module declaration?
DiamondLovesYou
force-pushed
the
backtrace-refactor
branch
2 times, most recently
from
9ca1ea8 to
7925c79
Compare
|
r? @alexcrichton (transferring ownership) |
|
⌛ Testing commit 7925c79 with merge 85901fb... |
|
💔 Test failed - auto-mac-64-opt |
|
Fixed (I think; I don't have a mac to test locally). |
|
@bors: r+ On Sat, Aug 22, 2015 at 9:54 AM Richard Diamond [email protected]
|
|
📌 Commit 6cbef95 has been approved by |
|
⌛ Testing commit 6cbef95 with merge 332ecc7... |
|
💔 Test failed - auto-mac-64-opt |
|
Fixed. |
No description provided.