Use handle.join() the same way in similarly structured examples #27924
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
||
| assert!(result.is_err()); | ||
| assert!(handle.join().is_err()); |
There was a problem hiding this comment.
I would actually prefer if we moved this join() out, instead: joining in an assert! feels very...strange.
There was a problem hiding this comment.
(like, add a line above with let result = handle.join() and then assert! on result.is_err().
kornelski
force-pushed
the
bookthreadjoin
branch
from
3beb175 to
d112274
Compare
|
Changed & squashed. |
|
@bors: r+ rollup |
|
📌 Commit d112274 has been approved by |
The chapter on concurrency has two examples that both start with:
let something = thread::spawn(…
but the returned values have different types, because the second example has `.join()` at the end of the expression.
I haven't noticed that join at first, and was wondering how is that possible that the result can have `.is_err()` and `.join()` methods.
I've changed the second example to have the same structure as the first, so they're easy to compare.
The chapter on concurrency has two examples that both start with:
but the returned values have different types, because the second example has
.join()at the end of the expression.I haven't noticed that join at first, and was wondering how is that possible that the result can have
.is_err()and.join()methods.I've changed the second example to have the same structure as the first, so they're easy to compare.