remove the is_instantiable check #28132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 321f8d8 has been approved by |
|
@bors r- |
|
actually, I was just wondering -- is it worth doing a crater run on this patch do you think? ah, I guess not. This might turn some well-structured errors into ICEs, but that's it. |
|
@bors r+ |
|
📌 Commit 321f8d8 has been approved by |
|
⌛ Testing commit 321f8d8 with merge ead182f... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors: retry On Tue, Sep 1, 2015 at 3:08 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
Sep 1, 2015
It is *very* easy to bypass, and is a relic of a bygone age where the type-checker was *much* less robust. Fixes #27497 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very easy to bypass, and is a relic of a bygone age where the type-checker was much less robust.
Fixes #27497
r? @nikomatsakis