Skip to content

Changed "functional structure update syntax" to "structure update syntax" #28175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2015
Merged

Changed "functional structure update syntax" to "structure update syntax" #28175

merged 1 commit into from
Sep 7, 2015

Conversation

alexispurslane
Copy link
Contributor

per #28168. This is my first contribution. I don't know who to "r?" for source code changes.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nrc
Copy link
Member

nrc commented Sep 2, 2015

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2015

📌 Commit f56a410 has been approved by nrc

@nrc
Copy link
Member

nrc commented Sep 2, 2015

@ChristopherDumas If you don't know who to r?, don't do anything and highfive will pick a suitable reviewer for you

@alexispurslane
Copy link
Contributor Author

Thanks! I noticed from "nrc was assigned by rust-highfive 3 minutes ago" message.

@alexispurslane
Copy link
Contributor Author

I'm really excited to start contributing to rust.

@steveklabnik
Copy link
Member

🎊

@bluss
Copy link
Member

bluss commented Sep 6, 2015

@bors r=nrc

@ChristopherDumas Don't forget to ping someone if you push an update to your PR. It should be on its way to merge now.

@bors
Copy link
Collaborator

bors commented Sep 6, 2015

📌 Commit cd9c9f0 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

⌛ Testing commit cd9c9f0 with merge 86156ac...

bors added a commit that referenced this pull request Sep 7, 2015
per #28168. This is my first contribution. I don't know who to "r?" for source code changes.
@bors bors merged commit cd9c9f0 into rust-lang:master Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants