Skip to content

Avoid loading the whole gdb debug scripts section. #28427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

DiamondLovesYou
Copy link
Contributor

This is so LLVM isn't forced to load every byte of it. Also sets the alignment of
the load. Adds a test for the debug script section.

r? @alexcrichton

@@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags: -C no-prepopulate-passes
// compile-flags: -C no-prepopulate-passes --crate-type=lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be specified with #![crate_type = "lib"] instead?

@DiamondLovesYou
Copy link
Contributor Author

Done.

@alexcrichton
Copy link
Member

@bors: r+ 6ba1af34f458bc2bc4a1d2ac9d69e502bb013b2d

@bors
Copy link
Collaborator

bors commented Sep 17, 2015

⌛ Testing commit 6ba1af3 with merge a92408f...

@bors
Copy link
Collaborator

bors commented Sep 17, 2015

💔 Test failed - auto-mac-32-opt

@DiamondLovesYou
Copy link
Contributor Author

Crap. Is there any way to view the build dir (ie
i686-apple-darwin/test/codegen/gdb_debug_script_load.ll)?

On Thu, Sep 17, 2015 at 12:45 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/6497


Reply to this email directly or view it on GitHub
#28427 (comment).

@alexcrichton
Copy link
Member

Nah unfortunately they're all blown away after each run

@DiamondLovesYou
Copy link
Contributor Author

Oh I don't need it. I just realized why it failed: the debug script is disabled on windows and on (drum roll please) Mac OSX. Derp.

@DiamondLovesYou
Copy link
Contributor Author

Fixed.

@alexcrichton
Copy link
Member

Looks like the failure on travis may be legit

This is so LLVM isn't forced to load every byte of it. Also sets the alignment of
the load. Adds a test for the debug script section.
@DiamondLovesYou
Copy link
Contributor Author

It was the result of a new codegen test. Fixed.

@alexcrichton
Copy link
Member

@bors: r+ 9a24025

bors added a commit that referenced this pull request Sep 22, 2015
…richton

This is so LLVM isn't forced to load every byte of it. Also sets the alignment of
the load. Adds a test for the debug script section.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Sep 22, 2015

⌛ Testing commit 9a24025 with merge f07f4ef...

@bors bors merged commit 9a24025 into rust-lang:master Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants