Fix run-make/bare-outfile test #28806
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Oh wow, thanks for this! Could this actually use |
The reason this was not failing is fascinating. The variable $(rustc) is empty, so the make recipe was expanded as " -o foo foo.rs". make interpreted this as an instruction to run the command "o foo foo.rs" and ignore any failure that occurred, because it uses a leading '-' on a command to signal that behavior.
wthrowe
force-pushed
the
bare-outfile-fix
branch
from
c51202e to
e3df519
Compare
|
Ah, yeah, that's a better way to do it. Changed. |
bors
added a commit
that referenced
this pull request
Oct 4, 2015
The reason this was not failing is fascinating. The variable $(rustc) is empty, so the make recipe was expanded as " -o foo foo.rs". make interpreted this as an instruction to run the command "o foo foo.rs" and ignore any failure that occurred, because it uses a leading '-' on a command to signal that behavior.
|
⌛ Testing commit e3df519 with merge 7f4665c... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this was not failing is fascinating. The variable $(rustc)
is empty, so the make recipe was expanded as " -o foo foo.rs". make
interpreted this as an instruction to run the command "o foo foo.rs"
and ignore any failure that occurred, because it uses a leading '-' on
a command to signal that behavior.