Build a MIR Map containing the MIR for each fn body #28866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // (*) the `Sized` and Debug` bounds are the only ones that really | ||
| // make sense. The rest are just there so that we can | ||
| // `#[derive(Clone)]` on things that are parameterized over | ||
| // `H:HAIR`. It's kind of lame. |
There was a problem hiding this comment.
Since this trait is being removed, are the panic-only trait implementation for Cx still needed?
https://github.com/rust-lang/rust/pull/28866/files#diff-ec73b70c7997781e552e837799fe63bfL170
There was a problem hiding this comment.
@ranma42 no, good point, thanks.
nikomatsakis
force-pushed
the
remove-hair-trait
branch
from
db21bc8 to
50c83a9
Compare
|
@bors: r+ |
|
📌 Commit 50c83a9 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 7, 2015
As the subject says. This PR also removes the `Hair` trait, which was impeding the ability to build such a map, as described in this thread on internals: https://internals.rust-lang.org/t/removing-the-hair-trait-from-mir-construction/2732 r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the subject says. This PR also removes the
Hairtrait, which was impeding the ability to build such a map, as described in this thread on internals:https://internals.rust-lang.org/t/removing-the-hair-trait-from-mir-construction/2732
r? @nrc