Document DST parameters on std::marker::Sized #29140
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -36,6 +36,17 @@ impl<T> !Send for *const T { } | |||
| impl<T> !Send for *mut T { } | |||
|
|
|||
| /// Types with a constant size known at compile-time. | |||
| /// | |||
| /// All type parameters which can be bounded have an implicit bound of Sized. The special syntax | |||
There was a problem hiding this comment.
Can you put Sized in backticks and change to one space after the period?
There was a problem hiding this comment.
I have no objection to that.
|
Thanks! Could you also squash these down into a single commit? |
|
@apasel422 Alright, but would somebody please update @rust-highfive to stop telling people to make separate commits for everything? |
This is for discoverability. If someone wants to know what ?Sized means, then Sized will be the only keyword they can use to search; so even though this is technically a language matter, it makes sense to document it where it will be looked for.
sorear
force-pushed
the
dst-document-on-sized
branch
from
e532f1d to
dc61d0f
Compare
|
Thanks @sorear! @rust-highfive is actually accurate in the sense that it's easier to review incremental changes as new commits, we just like to typically squash small PRs like this down to one commit before merging. |
|
⌛ Testing commit dc61d0f with merge 853adf8... |
|
@bors: retry force |
|
⌛ Testing commit dc61d0f with merge bd5697c... |
|
@bors: retry force |
|
⌛ Testing commit dc61d0f with merge fdcdd60... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Mon, Oct 19, 2015 at 8:24 PM, bors [email protected] wrote:
|
This is for discoverability. If someone wants to know what `?Sized` means, then Sized will be the only keyword they can use to search; so even though this is technically a language matter, it makes sense to document it where it will be looked for.
This is for discoverability. If someone wants to know what
?Sizedmeans, thenSized will be the only keyword they can use to search; so even though this is
technically a language matter, it makes sense to document it where it will be
looked for.