Skip to content

Add an error message for using typeof instead of an ICE #29243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Add an error message for using typeof instead of an ICE #29243

merged 1 commit into from
Oct 23, 2015

Conversation

skeleten
Copy link
Contributor

Fixes #29184

This adds an error message for the use of the reserved typeof keyword, instead of reporting an ICE.
Also adds a compile-fail test.

I chose to add a span_err instead of removing to parser code, as to preserve the reservation of typeof.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! Could you also squash these down to one commit?

@skeleten
Copy link
Contributor Author

I somehow seem to have screwed up my own fork. Mind If I close this, redo the stuff in a new fork, and open the PR again?

@arielb1
Copy link
Contributor

arielb1 commented Oct 23, 2015

@skeleten

Just squash the commits.

@skeleten
Copy link
Contributor Author

@arielb1
Isn't as easy if it is your first time rebasing ;) I think I did it anyways :P

@steveklabnik
Copy link
Member

@skeleten
Copy link
Contributor Author

Thanks, that'll be helpful :)

This adds error E0516

fixing a type pointed out by @jonas-schievink
@alexcrichton
Copy link
Member

@bors: r+ 044a8fe

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 23, 2015

⌛ Testing commit 044a8fe with merge 7ee4e9e...

bors added a commit that referenced this pull request Oct 23, 2015
Fixes #29184 

This adds an error message for the use of the reserved `typeof` keyword, instead of reporting an ICE.
Also adds a `compile-fail` test.

I chose to add a `span_err` instead of removing to parser code, as to preserve the reservation of `typeof`.
@bors bors merged commit 044a8fe into rust-lang:master Oct 23, 2015
@skeleten skeleten deleted the issue-29184 branch October 23, 2015 18:48
@skeleten skeleten restored the issue-29184 branch January 17, 2016 19:39
@skeleten skeleten deleted the issue-29184 branch January 17, 2016 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants