-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add an error message for using typeof
instead of an ICE
#29243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! Could you also squash these down to one commit? |
I somehow seem to have screwed up my own fork. Mind If I close this, redo the stuff in a new fork, and open the PR again? |
Just squash the commits. |
@arielb1 |
Thanks, that'll be helpful :) |
This adds error E0516 fixing a type pointed out by @jonas-schievink
Fixes #29184 This adds an error message for the use of the reserved `typeof` keyword, instead of reporting an ICE. Also adds a `compile-fail` test. I chose to add a `span_err` instead of removing to parser code, as to preserve the reservation of `typeof`.
Fixes #29184
This adds an error message for the use of the reserved
typeof
keyword, instead of reporting an ICE.Also adds a
compile-fail
test.I chose to add a
span_err
instead of removing to parser code, as to preserve the reservation oftypeof
.