Fix a few overflows with associated types #29313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me with nits fixed. |
I could have added a check for explicit recursion, as irregular types tend to cause selection errors, but I am not sufficiently sure that cannot be bypassed. Fixes rust-lang#22919 Fixes rust-lang#25639 Fixes rust-lang#26548
arielb1
force-pushed
the
projection-overflow
branch
from
9bc09fc to
1220e01
Compare
|
nits fixed |
|
@bors r+ |
|
📌 Commit 1220e01 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 28, 2015
This turns the crashes into overflow errors. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the crashes into overflow errors.
r? @eddyb