Skip to content

Removing unnecessary hack from the error handling chapter #29657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2015

Conversation

defuz
Copy link
Contributor

@defuz defuz commented Nov 6, 2015

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

You have an unrelated change in AUTHORS.txt, but r=me after! Thank you.

@defuz
Copy link
Contributor Author

defuz commented Nov 6, 2015

@steveklabnik What do you mean "unrelated change"? I just wanted to change the nickname to my real name in AUTHORS.txt. Should I create a separate request for this?

@steveklabnik
Copy link
Member

Sorry, your PR made no mention of it, and so it seemed to be out of the blue :) If that's something you meant to do, that's fine.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2015

📌 Commit 1ebdb73 has been approved by steveklabnik

@steveklabnik
Copy link
Member

(and thanks a lot for finding this!)

@bors
Copy link
Collaborator

bors commented Nov 6, 2015

⌛ Testing commit 1ebdb73 with merge b14dc5b...

bors added a commit that referenced this pull request Nov 6, 2015
@bors bors merged commit 1ebdb73 into rust-lang:master Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants