Skip to content

Fix example for the Debug trait so it matches the given output #29808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2015

Conversation

aphistic
Copy link
Contributor

The example given for the manual implementation of the core::fmt::Debug trait doesn't match the output after the code sample. This updates it so it matches.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2015

📌 Commit 83c3125 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 12, 2015
…=steveklabnik

The example given for the manual implementation of the core::fmt::Debug trait doesn't match the output after the code sample. This updates it so it matches.
bors added a commit that referenced this pull request Nov 13, 2015
The example given for the manual implementation of the core::fmt::Debug trait doesn't match the output after the code sample. This updates it so it matches.
@bors
Copy link
Collaborator

bors commented Nov 13, 2015

⌛ Testing commit 83c3125 with merge c10569c...

@sfackler
Copy link
Member

It might be worth using the debug builders API here if that won't involve introducing too many new concepts at once, since that's the common way to implement Debug manually.

@bors bors merged commit 83c3125 into rust-lang:master Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants