Skip to content

Resolved warnings about unused result in concurrency.md #30221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2015
Merged

Resolved warnings about unused result in concurrency.md #30221

merged 2 commits into from
Dec 6, 2015

Conversation

thyrgle
Copy link
Contributor

@thyrgle thyrgle commented Dec 5, 2015

The example code in the Channels subsection of the rust book give warnings about

unused result which must be used, #[warn(unused_must_use)] on by default

Added a small pattern match to resolve those warnings.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Perhaps these could be changed to .unwrap()? I think it indicates a program bug if Err is returned.

@thyrgle
Copy link
Contributor Author

thyrgle commented Dec 5, 2015

Thanks. Sorry about that. Uses .unwrap() instead of empty variable.

@alexcrichton
Copy link
Member

@bors: r+ bfb7361 rollu

Thanks!

@alexcrichton
Copy link
Member

@bors: rollup

@bors
Copy link
Collaborator

bors commented Dec 6, 2015

⌛ Testing commit bfb7361 with merge 078aff8...

bors added a commit that referenced this pull request Dec 6, 2015
The example code in the Channels subsection of the rust book give warnings about

    unused result which must be used, #[warn(unused_must_use)] on by default

Added a small pattern match to resolve those warnings.
@bors bors merged commit bfb7361 into rust-lang:master Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants