Skip to content

Update traits.md #30273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2015
Merged

Update traits.md #30273

merged 2 commits into from
Dec 9, 2015

Conversation

Xmasreturns
Copy link
Contributor

Changes to readability and some clarifications for beginners

Changes to readability and some clarifications for beginners
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@tshepang
Copy link
Member

tshepang commented Dec 8, 2015

The only nit I have is that those lines are overlong, at least as compared to the already existing ones, otherwise this is a 👍 from me.

@tshepang
Copy link
Member

tshepang commented Dec 8, 2015

One more thing, please squash these 2 commits. Either that, or give them more meaningful commit messages.

@Xmasreturns
Copy link
Contributor Author

@tshepang I used the edit button directly on the github file pages for these two commits, and I'm not familiar with git in shell, so I'm not sure how to squash the two together. That being said, I didn't look too hard for that function and added the second commit because it seemed like the right thing to do based on the autoresponse from rust-highfive.

@Xmasreturns
Copy link
Contributor Author

Also, when you say the lines are overlong, do you mean number of characters per line of code or do you mean number of words per sentence?

@tshepang
Copy link
Member

tshepang commented Dec 9, 2015

I meant characters per line.

@steveklabnik
Copy link
Member

We do generally try to wrap to 80 characters, and squash things down into less commits. However, I try to be a bit less lax with newer contributors, and I know we talked on IRC about git being a bit hard, so I don't think, in this case, it's a huge deal. I'm about to do a lot of editing to the book over the next week or two anyway.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 9, 2015

📌 Commit 88c407c has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 9, 2015
Changes to readability and some clarifications for beginners
bors added a commit that referenced this pull request Dec 9, 2015
@bors bors merged commit 88c407c into rust-lang:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants