Skip to content

Grammar and slight ordering changes #30292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2015
Merged

Conversation

Xmasreturns
Copy link
Contributor

Updated structs.md in the book

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -9,7 +9,8 @@ let origin_x = 0;
let origin_y = 0;
```

A `struct` lets us combine these two into a single, unified datatype:
A `struct` lets us combine these two into a single, unified datatype with `x`
and `y` as traits:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x and y are not traits here

Traits -> Field labels
Revert a change to convention
@Xmasreturns
Copy link
Contributor Author

Thanks for the heads up on the name: Type convention, I must've missed that while reading. Also, good catch on x/y - I definitely meant field labels there, sorry!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 9, 2015

📌 Commit 2adba31 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Dec 10, 2015

⌛ Testing commit 2adba31 with merge ee597a8...

bors added a commit that referenced this pull request Dec 10, 2015
@bors bors merged commit 2adba31 into rust-lang:master Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants