Skip to content

Add missing links to str docs #30342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2015
Merged

Add missing links to str docs #30342

merged 1 commit into from
Dec 13, 2015

Conversation

salty-horse
Copy link
Contributor

Many of the structs in str that are used as part of its methods do not have links to the methods.
This is especially annoying when a Google search drops you into the documentation of the struct, when you really wanted to get to the method of the same name.

This patch adds those links.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thank you so much!

@bors
Copy link
Collaborator

bors commented Dec 11, 2015

📌 Commit d01ec6c has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Dec 12, 2015

⌛ Testing commit d01ec6c with merge d3b5c2a...

@bors
Copy link
Collaborator

bors commented Dec 12, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Dec 12, 2015 at 12:16 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/7372


Reply to this email directly or view it on GitHub
#30342 (comment).

@bors
Copy link
Collaborator

bors commented Dec 13, 2015

⌛ Testing commit d01ec6c with merge d5cdf06...

bors added a commit that referenced this pull request Dec 13, 2015
Many of the structs in `str` that are used as part of its methods do not have links to the methods.
This is especially annoying when a Google search drops you into the documentation of the struct, when you really wanted to get to the method of the same name.

This patch adds those links.
@bors bors merged commit d01ec6c into rust-lang:master Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants