Add PNaCl target info to the makefile target cfgs and initialize the PNaCl target machine if available. #30401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // PNaCl doesn't provide some of the optional target components, so we | ||
| // manually initialize it here. | ||
| #[cfg(have_component_pnacl)] | ||
| fn init() { |
There was a problem hiding this comment.
Could this be init_pnacl b/c it's pnacl specific?
|
just one small nit but otherwise r=me |
DiamondLovesYou
force-pushed
the
pnacl-target
branch
from
f179350 to
aa9e66e
Compare
|
Done. |
|
@bors: r+ aa9e66eccffaf9077b1ecaaad9406d1bd43a9a4b |
|
⌛ Testing commit aa9e66e with merge c5f73c5... |
|
💔 Test failed - auto-win-msvc-64-opt |
…PNaCl target machine if available.
DiamondLovesYou
force-pushed
the
pnacl-target
branch
from
aa9e66e to
0442be8
Compare
|
Fixed. |
bors
added a commit
that referenced
this pull request
Dec 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton