Add an impl for Box<Error> from String. #30509
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 577b267138eda17809f891f50b70171cba2b2945 |
| @@ -119,6 +119,15 @@ impl From<String> for Box<Error + Send + Sync> { | |||
| } | |||
| } | |||
|
|
|||
| #[unstable(feature = "string_box_error", reason = "recently added", issue = "30156")] | |||
There was a problem hiding this comment.
Implementations aren't checked for stability so this should really be flagged stable.
There was a problem hiding this comment.
I was wondering about that. I'll amend the commit and do a push.
|
@alexcrichton this seems to have stalled (no acknowledgement from @bors), and the r+ needs to be on the new commit. It's holidays though so take it easy! 😄 |
|
Is there a reason why there is no similar implementation for |
|
@michaelsproul oh if the commit is updated it needs a new r+ As @netvl says actually, could you add an impl for |
|
Will fix it up soon. |
|
Updated! I really like the |
brson
added
the
beta-nominated
|
bhsausabsha on IRC asked for a backport |
|
backporting would solve this beta regression IIUC #30634 |
brson
added
the
beta-accepted
|
Per @nikomatsakis accepted for backport. This fixes another regression. |
brson
removed
the
beta-nominated
Closes #30156.