Add std::panic::propagate #30557
Add std::panic::propagate #30557
Conversation
|
Should this be attached to recover's tracking issue or have its own? |
| @@ -172,7 +172,7 @@ pub fn panicking() -> bool { | |||
| #[inline(never)] | |||
| #[no_mangle] | |||
| #[allow(private_no_mangle_fns)] | |||
There was a problem hiding this comment.
presumably can remove this allow if the fn is becoming public?
There was a problem hiding this comment.
Possibly - not sure how deeply that lint looks. This function is now public within its module, but not public outside of the crate.
There was a problem hiding this comment.
You're right, still required: http://is.gd/Z4qyRE
On Fri, Dec 25, 2015 at 8:37 PM, Steven Fackler [email protected]
wrote:
In src/libstd/sys/common/unwind/mod.rs
#30557 (comment):@@ -172,7 +172,7 @@ pub fn panicking() -> bool {
#[inline(never)]
#[no_mangle]
#[allow(private_no_mangle_fns)]Possibly - not sure how deeply that lint looks. This function is now
public within its module, but not public outside of the crate.—
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/30557/files#r48444144.
brson
added
I-nominated
T-libs-api
|
cc @rust-lang/libs |
| /// panic::propagate(err); | ||
| /// } | ||
| /// ``` | ||
| #[unstable(feature = "panic_propagate", reason = "awaiting feedback", issue = "0")] |
There was a problem hiding this comment.
This should have an actual issue before it lands.
sfackler
force-pushed
the
panic-propagate
branch
from
23d5903 to
022c9c7
Compare
|
@bors r=aturon We discussed this during libs triage today and are okay with it. |
|
📌 Commit 022c9c7 has been approved by |
See rust-lang/rfcs#1413.
r? @alexcrichton