f32: inline msvc-dispatched methods #30718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These don't compile at all. Fixing. |
|
Should be fixed. |
|
Closing in favor of #30719 due to communication failure. |
|
Sorry :( |
|
No problem :) On Tue, Jan 5, 2016 at 3:56 PM, Pyfisch [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #30657, but I don't have MSVC and I don't really know how to test whether a function got inlined or not.
This adds
#![feature(stmt_expr_attributes)]to std in order to eliminate the inner functions.I also added
#[inline]to the functions inmod shimsbut I am not sure if they are also necessary (legal?) on the extern declarations.r? @eddyb