Skip to content

Fix number of lines and methods in guessing game #31799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2016

Conversation

cshaffer
Copy link
Contributor

I noticed a few PRs fixing some of the words around the code refactor in the guessing game tutorial, this should be all that's left.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks so much!

On Sat, Feb 20, 2016 at 8:04 PM, Rust highfive robot <
[email protected]> wrote:

Thanks for the pull request, and welcome! The Rust team is excited to
review your changes, and you should hear from @Manishearth
https://github.com/manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra
commits. This ensures that the reviewer can see what has changed since they
last reviewed the code. Due to the way GitHub handles out-of-date commits,
this should also make it reasonably obvious what issues have or haven't
been addressed. Large or tricky changes may require several passes of
review and changes.

Please see the contribution instructions
https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md for more
information.


Reply to this email directly or view it on GitHub
#31799 (comment).

@bors
Copy link
Collaborator

bors commented Feb 21, 2016

📌 Commit 6e98593 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Feb 21, 2016

⌛ Testing commit 6e98593 with merge 80122b2...

bors added a commit that referenced this pull request Feb 21, 2016
I noticed a few PRs fixing some of the words around the code refactor in the guessing game tutorial, this should be all that's left.
@bors bors merged commit 6e98593 into rust-lang:master Feb 21, 2016
@cshaffer cshaffer deleted the book-fixes branch February 22, 2016 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants